Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI release config #41

Merged
merged 5 commits into from
Jan 2, 2022

Conversation

armanbilge
Copy link
Member

Two changes here:

  1. Add a tlCiReleaseTags option, default true. This is so you can disable releasing tags from CI, good for projects like CE that may want CI snapshots but not CI tags.
  2. Merge the tlCiReleaseSnapshots and tlCiReleaseBranches into a single setting tlCiReleaseSnapshotBranches, where you directly specify the branches you want snapshots from. Default is empty, which causes no snapshots to be released.

@armanbilge
Copy link
Member Author

Btw, I'm using "snapshots" in the loose sense here. Whether they are -SNAPSHOTS or not depends on your versioning scheme. Really, it's whether to release on every push—how it releases, is determined by the versioning scheme.

Comment on lines 29 to 30
lazy val tlCiReleaseSnapshotBranches = settingKey[Seq[String]](
"The branches in your repository to release snapshots from in CI (default: [])")
Copy link
Member Author

@armanbilge armanbilge Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lazy val tlCiReleaseSnapshotBranches = settingKey[Seq[String]](
"The branches in your repository to release snapshots from in CI (default: [])")
lazy val tlCiReleaseBranches = settingKey[Seq[String]](
"The branches in your repository to release from in CI on every push. Depending on your versioning scheme, they will be either snapshots or (hash) releases. (default: [])")

@armanbilge armanbilge merged commit 08387da into typelevel:main Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants