Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to apiURL if javadocioUrl does not exist #356

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

valencik
Copy link
Member

@valencik valencik commented Aug 14, 2022

Of note, this will yield a URL that does not exist when:

  • You run this on a dirty git workspace and thus have a timestamp as part of your snapshot
  • You run this on a commit that has not had a snapshot published

@armanbilge
Copy link
Member

You run this on a dirty git workspace and thus have a timestamp as part of your snapshot

I'd say this falls into case (2), when it's unpublished. Timestamped snapshots are also publishable :)

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. Thanks!

@armanbilge armanbilge merged commit 25c24d6 into series/0.4 Aug 14, 2022
@armanbilge armanbilge deleted the apiURL-fallback branch August 14, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants