Extract out a GitHub plugin #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Dec 31, 2021
| @@ -0,0 +1,2 @@ | |||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.7.1") | |||
There was a problem hiding this comment.
We have to be careful with our versioning strategy here. I'm rolling this back from 1.8 because otherwise I can't use it with http4s-dom which is currently blocked by upstream issues with 1.8, see http4s/http4s-dom#60 (comment).
rossabaker
approved these changes
Jan 2, 2022
| val GitHubGit = s"git://github.com:$identifier/$identifier(?:\\.git)?".r | ||
| val GitHubSsh = s"git@github.com:$identifier/$identifier(?:\\.git)?".r | ||
| Try { | ||
| val remote = List("git", "ls-remote", "--get-url", "origin").!!.trim() |
There was a problem hiding this comment.
Probably worth calling out this is how it works. Not everybody calls origin origin.
There was a problem hiding this comment.
True. I was mostly concerned with what the CI runners do, since you want to get this right on publish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yep, yet another plugin ...
This one automatically configures boilerplate settings (SCM info and Scala.js sourcemap URIs) assuming you are using GitHub. This was previously part of the settings plugin, but since it seems like many people don't want their scalac settings dictated to them I extracted out this less contentious part.