Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CI on update/* branches #291

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Don't run CI on update/* branches #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ name: Continuous Integration

on:
pull_request:
branches: ['**']
branches: ['**', '!update/**']
Copy link
Member Author

@armanbilge armanbilge Jun 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took me aback at first, because I thought it meant it would not run CI for PRs from branches named update/**. But, no, it won't run CI for PRs targeting branches named update/**.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this. Can't imagine how many times people were confused with this. Maybe it's just an attempt to get more traffic to docs? 😆

push:
branches: ['**']
branches: ['**', '!update/**']
tags: [v*]

env:
Expand Down
1 change: 1 addition & 0 deletions ci/src/main/scala/org/typelevel/sbt/TypelevelCiPlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ object TypelevelCiPlugin extends AutoPlugin {
tlCiScalafixCheck := false,
tlCiMimaBinaryIssueCheck := true,
tlCiDocCheck := true,
githubWorkflowTargetBranches += "!update/**", // ignore steward branches
githubWorkflowPublishTargetBranches := Seq(),
githubWorkflowBuild := {

Expand Down