More responsible skipping #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9fbd743.
armanbilge
commented
Feb 11, 2022
|
|
||
| private[sbt] def mkCommand(commands: List[String]): String = commands.mkString("; ", "; ", "") | ||
|
|
||
| private[sbt] def skipIfIrrelevant[T](task: TaskKey[T]) = { |
There was a problem hiding this comment.
I kept this private, but IMO it's worth exposing. For example http4s could use this for the unusedCompileDependenciesTest that was causing problems for the non-Scala 3 modules.
There was a problem hiding this comment.
Although, many tasks are not natively skippable (like test).
rossabaker
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140, this time for real.
Two changes:
skip := truefor a whole project. Instead set it task-by-task, for tasks where skipping is known to be "safe".