Merge pull request #134 from armanbilge/fix/generated-upload-steps

Don't generate artifact upload steps if not publishing
typelevel · Feb 4, 2022 · fab8815 · fab8815
2 parents 5fff779 + f10a979
commit fab8815
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/GenerativePlugin.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/GenerativePlugin.scala
@@ -565,7 +565,10 @@ ${indent(jobs.map(compileJob(_, sbt)).mkString("\n\n"), 1)}
     githubWorkflowPREventTypes := PREventType.Defaults,
     githubWorkflowArtifactDownloadExtraKeys := Set.empty,
     githubWorkflowGeneratedUploadSteps := {
-      if (githubWorkflowArtifactUpload.value) {
+      val generate =
+        githubWorkflowArtifactUpload.value &&
+          githubWorkflowPublishTargetBranches.value.nonEmpty
+      if (generate) {
         val sanitized = pathStrs.value map { str =>
           if (str.indexOf(' ') >= 0) // TODO be less naive
             s"'$str'"