Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to sbt-typelevel-ci-release #295

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Migrate to sbt-typelevel-ci-release #295

merged 3 commits into from
Jan 26, 2022

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Jan 21, 2022 •
edited
Loading

I cleaned up your build quite a bit. Please let me know if you have any questions!

@armanbilge armanbilge mentioned this pull request Jan 21, 2022
Open
44 tasks
danicheg
danicheg reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's huge! Also, it seems we need to change docs about the release process.

build.sbt Show resolved Hide resolved
@armanbilge
Copy link
Member Author

I updated the docs here, and you also reminded me to add some docs about releasing to sbt-typelevel itself 😅

danicheg
danicheg approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking great. So much code is gone ❤️

@danicheg
Copy link
Member

@benhutchison Hi, Ben! What do you think about this one? I think it's pretty good to go.

@danicheg
Copy link
Member

It's a good opportunity to make a pilot release when merging #297.

@danicheg danicheg merged commit da4a1a7 into typelevel:main Jan 26, 2022
@BalmungSan BalmungSan mentioned this pull request Jan 26, 2022
Merged
@benhutchison
Copy link
Member

Sorry @danicheg not sure how I missed the notify on this.. Anyway :thumbsup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armanbilge @danicheg @benhutchison