Blocker Slf4j Logger Backer #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
reviewed
Jul 5, 2023
slf4j/src/main/scala/org/typelevel/log4cats/slf4j/internal/Slf4jLoggerInternal.scala
Show resolved
Hide resolved
|
Thanks for iterating over this. LGTM! But let's wait for a while if other maintainers want to put their two cents on this. |
armanbilge
reviewed
Jul 9, 2023
slf4j/src/main/scala/org/typelevel/log4cats/slf4j/internal/Slf4jLoggerInternal.scala
Outdated
Show resolved
Hide resolved
|
Hey @diogocanut! Sorry for pinging, but your PR is good and I'd like to merge it, but there is a reasonable suggestion from @armanbilge. Could you glance at it? Otherwise, I can do a final polish if you don't mind. Thank you! |
armanbilge
reviewed
Jul 24, 2023
slf4j/src/main/scala/org/typelevel/log4cats/slf4j/internal/Slf4jLoggerInternal.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Jul 24, 2023
slf4j/src/main/scala/org/typelevel/log4cats/slf4j/Slf4jLogger.scala
Outdated
Show resolved
Hide resolved
|
Great work on collaborating and making a valuable contribution 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #440 .