Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable back-publishing in CI #206

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

armanbilge
Copy link
Member

Following from #205 (comment).

- name: Setup Java and Scala
uses: olafurpg/setup-scala@v13
with:
java-version: adopt@1.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't all the cool kids on temurin now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. The primary CI workflow on the main branch hasn't been updated, I just copy-pasted from there since that works.

@@ -505,6 +505,23 @@ command-line. For instance:
scalac -Xplugin:kind-projector_2.13.6-0.13.2.jar test.scala
```

### Releasing the plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably mention the workflow here.

@armanbilge
Copy link
Member Author

Screen Shot 2022-01-11 at 10 57 25

@armanbilge armanbilge requested a review from rossabaker January 11, 2022 19:11
@armanbilge armanbilge marked this pull request as ready for review January 11, 2022 19:11
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold off for another approval because part of it is mine, but 👍 to Arman's work.

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're cool, folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants