Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate on typelevel organization #314

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Conversation

danicheg
Copy link
Member

@danicheg danicheg commented Nov 2, 2021

This PR is mainly a proposal. Perhaps, this will also require changing the secrets for publishing.
What do you folks think about it? @cquiroz @ChristopherDavenport @rossabaker

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly don't mind. That was my intention 😄

@ChristopherDavenport
Copy link
Member

I think I can publish to typelevel already. And if not then I should go ask for that regardless. So I don't think creds should need to change.

@danicheg
Copy link
Member Author

danicheg commented Nov 8, 2021

@cquiroz sorry for yet another ping, but I think we can merge this and attempt to make a release under the typelevel org. It is a good question is preserve current versioning or start from blank (e. g. from 0.1.0). In the monoids we have gone ahead with 0.1.0.

@cquiroz
Copy link
Contributor

cquiroz commented Nov 8, 2021

Hi sorry, I thought it was mostly a question for Chris, but sure this sounds fine. In case publication fails I have credentials to publish under typelevel

Changing version number should be ok,
I think scala steward can handle the org change but I'm not sure if the version number has to keep up with the old org

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lukoyanov lukoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cquiroz
Copy link
Contributor

cquiroz commented Nov 10, 2021

It seems we could merge this and attempt a M1 release

@cquiroz cquiroz merged commit 0c6be56 into typelevel:main Nov 10, 2021
@cquiroz
Copy link
Contributor

cquiroz commented Nov 10, 2021

@cquiroz
Copy link
Contributor

cquiroz commented Nov 10, 2021

It seems adding a migration to scala-steward would be possible

@danicheg danicheg deleted the typelevel-org branch November 10, 2021 15:18
@danicheg
Copy link
Member Author

Great!

@cquiroz
Copy link
Contributor

cquiroz commented Nov 15, 2021

@cquiroz
Copy link
Contributor

cquiroz commented Nov 15, 2021

I'll release version 0.5.0 and setup the migration on scala-steward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants