Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build for Native #426

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Cross-build for Native #426

merged 3 commits into from
Jun 30, 2022

Conversation

armanbilge
Copy link
Member

Squashes #376 and brings it across the finish line.

armanbilge and others added 3 commits June 30, 2022 14:41
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this up!

@johnynek johnynek merged commit edd465d into typelevel:main Jun 30, 2022
@armanbilge
Copy link
Member Author

Hmm, seems that the merge commit edd465d lost the attribution to @i10416 in cdd3d4a ... I'm so sorry about that 😕

@@ -1,3 +1,5 @@
addSbtPlugin("org.portable-scala" % "sbt-scala-native-crossproject" % "1.2.0")
addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.4.4")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI, 0.4.5 enables building Scala 3 Native on Java 17 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot update this. No problem, there will be a steward update here shortly :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i10416
Copy link
Contributor

i10416 commented Jun 30, 2022

Hmm, seems that the merge commit edd465d lost the attribution to @i10416 in cdd3d4a ... I'm so sorry about that 😕

No worries. Thanks for taking over my PR. I was a bit occupied :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants