Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor issues before 0.3.5 #305

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix some minor issues before 0.3.5 #305

merged 1 commit into from
Nov 12, 2021

Conversation

johnynek
Copy link
Collaborator

I realized we used line instead of row in the LocationMap and we had a doc error that caused v0.3.5 publish to fail, so I figured I could fix that.

@johnynek johnynek requested a review from regadas November 12, 2021 18:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #305 (a6c7f5f) into main (af1bc74) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           9        9           
  Lines        1048     1048           
  Branches      101      101           
=======================================
  Hits         1014     1014           
  Misses         34       34           
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Caret.scala 100.00% <100.00%> (ø)
...shared/src/main/scala/cats/parse/LocationMap.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1bc74...a6c7f5f. Read the comment docs.

@johnynek
Copy link
Collaborator Author

I am going to exercise a rare self merge so we can get this published today.

I think consistency with LocationMap.toLineCol means we should use line in Caret.

@johnynek johnynek merged commit c1ffc4b into main Nov 12, 2021
@johnynek johnynek deleted the oscar/fixup branch November 12, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants