Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize charWhere for Sets #288

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Optimize charWhere for Sets #288

merged 1 commit into from
Oct 29, 2021

Conversation

johnynek
Copy link
Collaborator

Since Set[Char] extends Char => Boolean but we can also enumerate it directly, we can directly call charIn rather than exhaustively checking the function.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #288 (ea01e47) into main (eee5032) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   96.36%   96.37%           
=======================================
  Files           8        8           
  Lines         991      992    +1     
  Branches       95       91    -4     
=======================================
+ Hits          955      956    +1     
  Misses         36       36           
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.28% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee5032...ea01e47. Read the comment docs.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 really nice one!

@johnynek johnynek merged commit 70f3fa0 into main Oct 29, 2021
@johnynek johnynek deleted the oscar/optimize_charwhere_set branch October 29, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants