Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FunctorEmpty and TraverseEmpty #51

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Remove FunctorEmpty and TraverseEmpty #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e2596a
Remove FunctorEmpty and TraverseEmpty
stephen-lazaro Aug 21, 2018
0400429
Add back ReaderWriterStateTInstances
stephen-lazaro Aug 26, 2018
1cf0f66
Merge branch 'master' into remove_empty_classes
Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions core/src/main/scala/cats/mtl/FunctorEmpty.scala
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions core/src/main/scala/cats/mtl/TraverseEmpty.scala
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions core/src/main/scala/cats/mtl/hierarchy/BaseHierarchy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ trait BaseHierarchy extends BH0
object base extends BaseHierarchy

private[hierarchy] trait BH0 extends BH1 {
implicit final def functorEmptyFromTraverseEmpty[F[_]](implicit F: TraverseEmpty[F]): FunctorEmpty[F] = F.functorEmpty

implicit final def askFromLocal[F[_], E](implicit local: ApplicativeLocal[F, E]): ApplicativeAsk[F, E] = local.ask

implicit final def tellFromListen[F[_], L](implicit listen: FunctorListen[F, L]): FunctorTell[F, L] = listen.tell
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/cats/mtl/instances/all.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ trait AllInstances extends EitherTInstances
with RaiseInstances with ReaderTInstances
with LocalInstances with StateInstances
with StateTInstances with WriterTInstances
with EmptyInstances with ReaderWriterStateTInstances
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually it's not odd, you deleted them here 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my God 🤦‍♂️
Amazing. Thanks Luka, will fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, fixed now!

with ReaderWriterStateTInstances
with HandleInstances
with ChronicleInstances with IorTInstances
Loading