Migrate to cats 1.0.0-RC1 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 95.14% 95.17% +0.02%
==========================================
Files 57 55 -2
Lines 515 518 +3
Branches 2 3 +1
==========================================
+ Hits 490 493 +3
Misses 25 25
Continue to review full report at Codecov.
|
- Remove TraverseEmpty instance for Map (cats core no longer provides a Traverse instance for Map as it is unlawful) - Add FunctorEmpty instance for Map - Add TraverseEmpty instance for SortedMap - Replace usage of deprecated Kleisli.transform with Kleisli.mapK - Remove usages of deprecated cartesian syntax
|
Can anyone help me understand why the build failed? |
|
thanks very much @denisrosca! LGTM, we are in the processing of establishing the maintainer team for cats-mtl. After that we shall be able to merge this one. |
Closed
kailuowang
approved these changes
Nov 7, 2017
SystemFw
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TraverseEmpty instance for Map (cats core no longer provides a
Traverse instance for Map as it is unlawful)
Add FunctorEmpty instance for Map
Add TraverseEmpty instance for SortedMap
Replace usage of deprecated Kleisli.transform with Kleisli.mapK
Remove usages of deprecated cartesian syntax