Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread blocking detection docs #3416

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Thread blocking detection docs #3416

merged 2 commits into from
Feb 16, 2023

Conversation

TimWSpence
Copy link
Member

No description provided.

djspiewak
djspiewak approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

docs/core/starvation-and-tuning.md
```scala
object Example extends IOApp.Simple {

override protected def blockedThreadDetectionEnabled = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛳

Suggested change
override protected def blockedThreadDetectionEnabled = true
override def blockedThreadDetectionEnabled = true

The protected is just noise. :-)

@djspiewak djspiewak merged commit 204fca2 into typelevel:series/3.x Feb 16, 2023
@TimWSpence TimWSpence deleted the thread-blocking-detection-docs branch February 17, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
📚 docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWSpence @djspiewak