Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated value field for backward source compatibility with http4s CaseInsensitiveString #182

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

bplommer
Copy link
Contributor

@bplommer bplommer commented Oct 7, 2021

Related to http4s/http4s#5344

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could aid people upgrading from http4s-0.21, but when that's done, this cruft is forever. Or at least until case-insensitive-2, which I hope doesn't need to happen. 🤔

@rossabaker
Copy link
Member

It's similar to http4s/http4s#5344, but people who have found their way to this type have already changed code. (Still thinking out loud).

@bplommer
Copy link
Contributor Author

bplommer commented Oct 7, 2021

This could aid people upgrading from http4s-0.21, but when that's done, this cruft is forever.

True 😕 it could be added to http4s as an extension instead along with .ci, though that wouldn't catch all uses.

@bplommer
Copy link
Contributor Author

bplommer commented Oct 7, 2021

but people who have found their way to this type have already changed code.

Not necessarily - various things return CIString that previously returned CaseInsensitiveString, and once that PR is merged the aliases will automatically forward them to this type.

@rossabaker
Copy link
Member

That's a good point.

@rossabaker
Copy link
Member

Let's do it. Deprecation handholding is nice.

@rossabaker rossabaker merged commit cbdbf3c into typelevel:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants