Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow passing bytes for Field verbose_name #1170

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Disallow passing bytes for Field verbose_name #1170

merged 1 commit into from
Sep 27, 2022

Conversation

intgr
Copy link
Collaborator

@intgr intgr commented Sep 27, 2022

As discussed in #1168 Field verbose_name argument should not accept bytes.

Also fixed an omission in GenericIPAddressField that had verbose_name type Any.

@intgr
Disallow passing bytes for field verbose_name
1298c13 
`verbose_name` is intended to be a human-readable string, not binary.
sobolevn
sobolevn approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 56f74f1 into typeddjango:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @sobolevn