Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Unapproved but successful workflows should show as green #78

Closed
jmsfltchr opened this issue Jul 30, 2019 · 1 comment
Closed

Unapproved but successful workflows should show as green #78

jmsfltchr opened this issue Jul 30, 2019 · 1 comment

Comments

@jmsfltchr
Copy link
Contributor

jmsfltchr commented Jul 30, 2019

Problem to Solve

A CI workflow which reaches an approval step, where approval is not given, is indicated as pending (orange). This is misleading as it gives the impression that tests have not passed. Approval is only given when releasing, so this problem is very common.

Current Workaround

Inspect the pending flag to see how far the workflow progressed

Proposed Solution

Use a custom approval system

@jmsfltchr jmsfltchr added this to the 0.1.1 milestone Jul 30, 2019
jmsfltchr added a commit that referenced this issue Sep 18, 2019
## What is the goal of this PR?

Create a more versatile approach to KGCNs, one that can be customised to perform:
- Relation prediction
- Attribute value prediction
- Subgraph prediction
- Graph optimisation
- Generation of Concept embeddings

## What are the changes implemented in this PR?

Overwrites the entirety of the KGCN project with a more advanced version. This new approach uses a learned message-passing algorithm, implemented in TensorFlow. The algorithm can predict node, edge and global properties for any input graph.

Implemented is a method to predict new Relations in extracted subgraphs, picking from a provided set of candidate relations.

Solves #51, #78, #42
@jmsfltchr
Copy link
Contributor Author

Solved by #85

@jmsfltchr jmsfltchr modified the milestones: 0.1.1, 0.2 Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants