Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ember-cli-typescript-blueprints no longer claims highest priority #323

Merged
merged 4 commits into from
Oct 1, 2018
Merged

fix: ember-cli-typescript-blueprints no longer claims highest priority #323

merged 4 commits into from
Oct 1, 2018

Conversation

mike-north
Copy link
Contributor

Fixes #322

dfreeman
dfreeman approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@dfreeman dfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dfreeman
Copy link
Member

dfreeman commented Oct 1, 2018

Based on the test failures, I think we need to update the before entry here to have the same constraints as the blueprints.

@dfreeman dfreeman merged commit 3503e80 into master Oct 1, 2018
@dfreeman dfreeman deleted the addon-ordering branch October 1, 2018 23:13
This was referenced Nov 4, 2018
Merged
Merged
@renovate renovate bot mentioned this pull request Dec 5, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreeman dfreeman dfreeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-north @dfreeman