Skip to content

Commit

Permalink
buildifier lint presubmit changes.
Browse files Browse the repository at this point in the history
- Enable checks for rule-impl-return.
- Use the new bazelci support to disable the warnings current giving false positives.
- Remove travis configuration since bazelci now supports everything.

RELNOTES: None
PiperOrigin-RevId: 237260583
  • Loading branch information
thomasvl authored and allevato committed Mar 7, 2019
1 parent f8c1941 commit 30b90b1
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 98 deletions.
7 changes: 6 additions & 1 deletion .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,9 @@ tasks:
- "//examples/..."
- "-//examples/apple/..."

buildifier: latest
buildifier:
version: latest
# uninitialized has issues:
# - https://github.com/bazelbuild/buildtools/issues/549
# - https://github.com/bazelbuild/buildtools/issues/550
warnings: -uninitialized
27 changes: 0 additions & 27 deletions .travis.yml

This file was deleted.

5 changes: 1 addition & 4 deletions .travis/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ if [[ -n "${BUILDIFIER:-}" ]]; then
# uninitialized has issues:
# - https://github.com/bazelbuild/buildtools/issues/549
# - https://github.com/bazelbuild/buildtools/issues/550
# rule-impl-return doesn't deal well with having to return
# legacy style, work being done to help with this, just
# not ready yet.
--warnings=-rule-impl-return,-uninitialized
--warnings=-uninitialized
)

# Check for lint issues?
Expand Down
65 changes: 0 additions & 65 deletions .travis/install.sh

This file was deleted.

1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Swift Rules for [Bazel](https://bazel.build)

[![Build Status](https://travis-ci.org/bazelbuild/rules_swift.svg?branch=master)](https://travis-ci.org/bazelbuild/rules_swift)
[![Build status](https://badge.buildkite.com/d562b11425e192a8f6ba9c43715bc8364985bccf54e4b9194a.svg)](https://buildkite.com/bazel/rules-swift-swift)

This repository contains rules for [Bazel](https://bazel.build) that can be
Expand Down

0 comments on commit 30b90b1

Please sign in to comment.