Skip to content

Commit

Permalink
CI: drop 3.6 & ubuntu switch
Browse files Browse the repository at this point in the history
* the Github Actions infrastructure is progressively
phasing in a newer base image of Ubuntu:
https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

* that means that we are somewhat randomly going to
see images that lack Python `3.6` from the build cache
sometimes per:
actions/setup-python#355 (comment)

* instead of pinning to an old version of Ubuntu in GHA for
3.6 support, let's just drop 3.6 from the testing matrix
per:
darshan-hpc#510 (comment)
(it has been EOL for 1 year)

* there's also no reason to retain the special Python `3.10`
handling where we use Ubuntu `22.04` for that case, for two reasons:
1) `22.04` is being rolled out as the new default anyway
2) darshan-hpcgh-851 with the Python garbage collection issues in `3.10` was
resolved by using contexts, so special treatment not justified
anymore
  • Loading branch information
tylerjereddy committed Dec 7, 2022
1 parent 1f9b275 commit d899a7a
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions .github/workflows/main_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,7 @@ jobs:
matrix:
platform: [ubuntu-latest,
macos-latest]
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]
# see gh-851
exclude:
- platform: ubuntu-latest
python-version: "3.10"
include:
- platform: ubuntu-22.04
python-version: "3.10"
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -89,10 +82,7 @@ jobs:
cd $RUNNER_TEMP
site_packages=$(pip show darshan | grep Location | cut -d ' ' -f 2)
pytest -W error::FutureWarning -W error:"The join function was deprecated in Matplotlib" --pyargs darshan --cov-report xml --cov=$site_packages/darshan
# Python 3.6 doesn't have access to some
# dependencies needed for our type hints
- if: ${{matrix.python-version > 3.6}}
name: mypy check
- name: mypy check
run: |
export LD_LIBRARY_PATH=$PWD/darshan_install/lib
export DYLD_FALLBACK_LIBRARY_PATH=$PWD/darshan_install/lib
Expand Down

0 comments on commit d899a7a

Please sign in to comment.