Skip to content

Commit

Permalink
Fix minor issues and leftovers (#63)
Browse files Browse the repository at this point in the history
Co-authored-by: Juan Manuel "Kang" Perez <devel@kangmak.es>
  • Loading branch information
kang-makes and Juan Manuel "Kang" Perez authored Apr 7, 2023
1 parent d04d9e3 commit 547b3c1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion charts/stateless-dns/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ Selector labels
{{- define "stateless-dns.selectorLabels" -}}
app.kubernetes.io/name: {{ include "stateless-dns.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/component: external-dns
{{- end }}


Expand Down
3 changes: 2 additions & 1 deletion charts/stateless-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,11 @@ externalDNS:
# 3. Ensure a blank `%{record_type}` does not leave trailing or leading dots or dashes, or two consecutive dashes.
txtPrefix: "in%{record_type}.stateless-dns." # Each of the entries added by external-dns will create a TXT entry in the DNS too to mark external-dns as it owner. The TXT entry name will be the entry that is being created plus this prefix. For furhter information of this default, please, refer to the long comment inside `values.yaml`
txtSuffix: "" # Same as above but TXT entries are decorated with a suffix instead of a prefix.
txtWildcardReplacement: "" # For more information on how TXT entries are created refer to the doc of `txtPrefix`. This is the prefix added to wildcard entries as they cannot be calculated.
txtWildcardReplacement: "wildcard" # For more information on how TXT entries are created refer to the doc of `txtPrefix`. This is the prefix added to wildcard entries as they cannot be calculated.
# external-dns refuses to send records that has a trailing dot.
# PowerDNS refuses to accept domain without a trailing dot.
# That makes impossible to support NS and MX types. So these types have to be in the declared at "zones" in the values.
# During the testing we were able to create only "A" and "TXT" records with this setup.
managedRecordTypes: # Entry types that external-dns will be able to create in the provider. NS and MX entries are unsupported, for more information read the full explanation in the `values.yaml`.
- A

Expand Down

0 comments on commit 547b3c1

Please sign in to comment.