Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove [all] target from pyproject and CI because it lags CI badly #1642

Merged
merged 1 commit into from
Oct 5, 2022
Merged

remove [all] target from pyproject and CI because it lags CI badly #1642

merged 1 commit into from
Oct 5, 2022

Conversation

mwartell
Copy link
Contributor

@mwartell mwartell commented Oct 5, 2022

The [all] target causes 2+ hour pip installations because it is computationally hard when versions are unpinned. Also, we don't need such an installation.

@mwartell mwartell marked this pull request as ready for review October 5, 2022 20:40
@mwartell mwartell mentioned this pull request Oct 5, 2022
Merged
christopherwoodall
christopherwoodall approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@christopherwoodall christopherwoodall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I still think the "all" target is valid, I see no issue in removing it.

@davidslater davidslater merged commit 6ef8d54 into develop Oct 5, 2022
@davidslater davidslater deleted the delete-all-pip-target branch October 5, 2022 21:28
@mwartell mwartell mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherwoodall christopherwoodall christopherwoodall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwartell @christopherwoodall @davidslater