Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch / Exec - better defaults #1636

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

davidslater
Copy link
Contributor

This makes two small changes:

  1. Instead of "launch" defaulting to a no-op and shutting down without --interactive or --jupyter provided, it now defaults to --interactive:
armory launch pytorch
  1. Instead of "exec" erroring out when no command line args are given, it defaults to a no-op.
armory exec pytorch --

Exec will still error if the -- delimiter is not present.

@davidslater davidslater requested a review from mwartell October 4, 2022 21:31
@davidslater davidslater changed the base branch from master to develop October 4, 2022 21:31
@mwartell mwartell merged commit 26f1b70 into twosixlabs:develop Oct 5, 2022
@davidslater davidslater deleted the launch-exec-no-op branch October 5, 2022 15:19
@mwartell mwartell mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants