rewrite using Symfony token hooks and TokenProcessor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks @MegaphoneJon I've got this scheduled for review (and hopefully merging) on Monday. |
twomice
reviewed
Jul 4, 2022
twomice
reviewed
Jul 4, 2022
2a8b0c7 to
a860fe8
Compare
twomice
added a commit
that referenced
this pull request
Jul 11, 2022
|
Merged manually (with some changes) in cf2e2c1 and b788e45 . Tagged in new version v0.4.0. Thanks @MegaphoneJon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp - someone had to do it eventually, right?
This is a rewrite of reltoken to use the newer Symfony token events, and use TokenProcessor to render tokens.
I added Flexmailer as a dependency because CiviMail without Flexmailer won't use the new Symfony events.
This is meant to be a rewrite following the original logic as closely as possible, and should have comparable performance. Now that we're using TokenProcessor I think we can render all tokens for a given related contact with a single TokenProcessor, which should yield a modest speed boost.