Fix issue #7: add default values for relationshipTypes custom field g… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field generate tokens
twomice
reviewed
Jun 29, 2021
reltoken.php
Outdated
| 'is_active' => 1, | ||
| 'api.RelationshipType.create' => [ | ||
| 'name_a_b' => '$value.name_a_b', | ||
| 'name_b_a' => '$value.name_b_a', |
There was a problem hiding this comment.
@lucky091588 Seems redundant to set name_a_b and name_b_a. Is that necessary?
There was a problem hiding this comment.
@twomice It is necessary since it is a mandatory field when using RelationshipType create in api3.
There was a problem hiding this comment.
@twomice I just confirmed that it's not necessary since it has the id with a value which means updating.
|
Merged, thanks @lucky091588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enerate tokens