Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 #10

Merged
merged 40 commits into from
Nov 27, 2021
Merged

4 #10

merged 40 commits into from
Nov 27, 2021

Conversation

twof
Copy link
Owner

@twof twof commented Dec 29, 2019

No description provided.

@twof twof self-assigned this Jan 3, 2020
@twof twof added the enhancement New feature or request label Jan 3, 2020
@carlostrianag
Copy link

Is this already working with Vapor 4?

@simonedelmann
Copy link
Contributor

I am not the maintainer of this project, but I wrote a similar package compatible with Vapor 4: https://github.com/simonedelmann/crud-kit

@twof
Copy link
Owner Author

twof commented Nov 21, 2021

I don't remember what state this is in, but it probably doesn't build at the moment. I got stuck implementing recursive relations ie a model has a parent which has siblings which have children.

Other people should feel free to pick up where I left off, and @simonedelmann 's library looks great as an alternative.

@simonedelmann
Copy link
Contributor

@twof Back then I only made my version of a Crud Router because of this PR not being ready.
I just noticed you are working on this again! I would be happy to deprecate my package, if this one is actively maintained again!

@twof
Copy link
Owner Author

twof commented Nov 21, 2021

@simonedelmann I have some time this morning, so I'll see if I can get this working again. I'll let you know! Your project also has a lot of features that mine doesn't, so if I can get this working again, maybe we can find a way to combine them.

@twof
Copy link
Owner Author

twof commented Nov 22, 2021

Recursive relations are giving me trouble again, but I'm more confident that I can sort it out this time around. Swift's errors around generic type mismatches have improved dramatically.

@twof
Copy link
Owner Author

twof commented Nov 26, 2021

Alright we're looking good. I'm going to get all public APIs nice and documented and then I'll tag a release!

@twof
Copy link
Owner Author

twof commented Nov 27, 2021

I'm gonna tag a release. We've got the relevant public methods documented now. @simonedelmann I'll see if my work can be added to your library at some point.

@twof twof merged commit e9e12d9 into master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants