Fix compilation with -DHAVE_STATS=0 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,9 @@ rbuf_destroy(struct rbuf *buf) | |||
| log_verb("Destroy ring buffer %p", buf); | |||
|
|
|||
| if (buf != NULL) { | |||
| #if defined CC_STATS && CC_STATS == 1 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
This is the warning:
/home/seppo/Projects/pelikan/deps/ccommon/src/cc_rbuf.c: In function 'rbuf_destroy':
/home/seppo/Projects/pelikan/deps/ccommon/src/cc_rbuf.c:99:18: warning: unused variable 'cap' [-Wunused-variable]
uint32_t cap = buf->cap;
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -443,8 +446,10 @@ cuckoo_suite(void) | |||
| tcase_add_test(tc_basic_req, test_delete_basic_random_false); | |||
| tcase_add_test(tc_basic_req, test_expire_basic_random_true); | |||
| tcase_add_test(tc_basic_req, test_expire_basic_random_false); | |||
| #if defined CC_STATS && CC_STATS == 1 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
If you cannot at least run a subset of the tests when stats is off, how do you even know if its behavior is correct?
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@thinkingfish do you think we can merge this now? |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
michalbiesek
added a commit
to michalbiesek/pelikan
that referenced
this pull request
Jun 7, 2019
Fix cleaning after partial request and code cleanup
swlynch99
pushed a commit
to swlynch99/pelikan-twitter
that referenced
this pull request
Sep 30, 2019
Add cc_array expand test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.