-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serializing asJavaIterable. #192
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
chill-scala/src/main/scala/com/twitter/chill/JavaIterableWrapperSerializer.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package com.twitter.chill | ||
|
||
import _root_.java.lang.{ Iterable => JIterable } | ||
|
||
/** | ||
* A Kryo serializer for serializing results returned by asJavaIterable. | ||
* | ||
* The underlying object is scala.collection.convert.Wrappers$IterableWrapper. | ||
* Kryo deserializes this into an AbstractCollection, which unfortunately doesn't work. | ||
* | ||
* Ported from Apache Spark's KryoSerializer.scala. | ||
*/ | ||
private class JavaIterableWrapperSerializer extends KSerializer[JIterable[_]] { | ||
|
||
import JavaIterableWrapperSerializer._ | ||
|
||
override def write(kryo: Kryo, out: Output, obj: JIterable[_]): Unit = { | ||
// If the object is the wrapper, simply serialize the underlying Scala Iterable object. | ||
// Otherwise, serialize the object itself. | ||
if (obj.getClass == wrapperClass && underlyingMethodOpt.isDefined) { | ||
kryo.writeClassAndObject(out, underlyingMethodOpt.get.invoke(obj)) | ||
} else { | ||
kryo.writeClassAndObject(out, obj) | ||
} | ||
} | ||
|
||
override def read(kryo: Kryo, in: Input, clz: Class[JIterable[_]]): JIterable[_] = { | ||
kryo.readClassAndObject(in) match { | ||
case scalaIterable: Iterable[_] => | ||
scala.collection.JavaConversions.asJavaIterable(scalaIterable) | ||
case javaIterable: JIterable[_] => | ||
javaIterable | ||
} | ||
} | ||
} | ||
|
||
private object JavaIterableWrapperSerializer { | ||
// The class returned by asJavaIterable (scala.collection.convert.Wrappers$IterableWrapper). | ||
val wrapperClass = scala.collection.JavaConversions.asJavaIterable(Seq(1)).getClass | ||
|
||
// Get the underlying method so we can use it to get the Scala collection for serialization. | ||
private val underlyingMethodOpt = { | ||
try Some(wrapperClass.getDeclaredMethod("underlying")) catch { | ||
case e: Exception => | ||
None | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this maybe be split out as a separate class from the normal collections -- I presume eventually we may want all the collections wrappers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's a decision for the project lead(s) ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then, lets do that so. Split out the wrappers from the core collections.