Added serialisation for SortedSet and ListSet. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val tRef = t.asInstanceOf[AnyRef] | ||
| kser.writeClassAndObject(out, tRef) | ||
| // After each intermediate object, flush | ||
| out.flush() |
There was a problem hiding this comment.
Why flush after each object?
There was a problem hiding this comment.
Because that is what Traversable does https://github.com/twitter/chill/blob/develop/chill-scala/src/main/scala/com/twitter/chill/Traversable.scala#L31.
I think @johnynek added Traversable maybe he can comment on why or if that is needed here.
There was a problem hiding this comment.
If you don't flush, the Kryo output can overflow.
johnynek
added a commit
that referenced
this pull request
Nov 4, 2013
Added serialisation for SortedSet and ListSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added serialisation for immutable.SortedSet. I wanted to make it more generic but I couldn't figure out how to use CanBuildFrom and enforce the ordering. So any pointers on that would be welcome.
I threw in a fix for ListSet as well, since I was using it to test things.
Once this has been added, is it possible to propagate the fix to Scalding. I would like to use the CountMinSketch from Algebird which uses a SortedSet and currently that blows up.