new-style wire protocol implementation for find*() methods #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still want to move this forward? |
|
No, this will be superseded by OP_MSG implementation on which we are working here: https://github.com/IlyaSkriblovsky/txmongo/tree/op-msg-support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from maxWireVersion=4 (v3.2) MongoDB migrated to new implementation of CRUD methods based on commands commands instead of
OP_*low-level message codes.We already support new-style commands for insert, update, replace and delete (when called as
*_one/*_many). This patch adds support for find*() methods too and uses it by default if maxWireVersion ≥ 4.This also (hopefully) makes txmongo compatible with Azure's Cosmos DB that only supports new-style API.
In future this will allow us to support sessions and transactions because it only supported for new-style queries.