Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 21.9.0 #360

Merged
merged 8 commits into from
Feb 10, 2022
Merged

Release 21.9.0 #360

merged 8 commits into from
Feb 10, 2022

Conversation

adiroiban
Copy link
Member

This is the release branch for 21.9.0

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #360 (4de07a7) into master (0e6a479) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          20       20           
  Lines        1194     1194           
  Branches      108      118   +10     
=======================================
  Hits         1156     1156           
  Misses         20       20           
  Partials       18       18           
Impacted Files Coverage Δ
src/towncrier/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6a479...4de07a7. Read the comment docs.

@adiroiban
Copy link
Member Author

Please check that the release candidate is ok https://pypi.org/project/towncrier/21.9.0rc1/

If you have tested , please report the test results here.

Thanks!

@decaz
Copy link

decaz commented Jan 30, 2022

@adiroiban RC was tested for a long time and it 21.9.0 can be released now.

@adiroiban
Copy link
Member Author

Thanks for the confirmation.
I have pushed the final release.

@decaz
Copy link

decaz commented Feb 4, 2022

@adiroiban could you upload it on PyPI, please?

@adiroiban
Copy link
Member Author

doing that. If all is ok, please review and approve this PR :p

@decaz
Copy link

decaz commented Feb 4, 2022

@adiroiban there is still version 21.3.0 on PyPI. Are you trying to upload version 21.9.0 or 22.2.0?

@adiroiban
Copy link
Member Author

I am trying to do the release...but first I/we need to get all CI green.

Right now " CI / Check Newsfragment - CPython 3.8 (pull_request) " is failing.

I guess that it's not happy that this branch has no release note fragmets.

The CI needs to be updated to accept this case :)

@adiroiban
Copy link
Member Author

@adiroiban
Copy link
Member Author

I have relaxed the PR merge rules to allow a merge even without an approved review.

This PR was waiting since September to be reviewed and nobody step in.

So I will consider that the project is now in "emergency mode" and we will try to move it forward as best as we can :(

@adiroiban adiroiban merged commit e0d72c4 into master Feb 10, 2022
@adiroiban adiroiban deleted the release-21.9.0 branch February 10, 2022 19:26
@decaz
Copy link

decaz commented Feb 10, 2022

@adiroiban thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants