fix(select): Disabled Select should use color-background #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 2e5dbc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
04487ce to
fc29ce0
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2e5dbc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +9 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e5dbc0:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-select-bg
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
nkrantz
reviewed
Dec 17, 2024
| @@ -110,6 +110,7 @@ export const SelectElement = React.forwardRef<HTMLSelectElement, SelectProps>( | |||
| width="100%" | |||
| _disabled={{ | |||
| color: variant === "inverse" ? "colorTextInverseWeakest" : "colorTextWeaker", | |||
| backgroundColor: "transparent", | |||
There was a problem hiding this comment.
do we have any way of testing this on windows? might be safer to set it to the actual desired token for disabled rather than transparent
There was a problem hiding this comment.
I tested on my personal windows using the deploy preview. I compared it against what is currently in prod and works for both light and dark themes
There was a problem hiding this comment.
I used browerstack to test it and works for me too
krisantrobus
approved these changes
Dec 17, 2024
serifluous
approved these changes
Dec 17, 2024
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-select-bg
|
| Run status |
|
| Run duration | 06m 00s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://paste-docs-git-fix-select-bg-twilio.vercel.app/components/select#disabled-select