-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table,datagrid): noWrap prop regression #3757
Conversation
|
🦋 Changeset detectedLatest commit: 94e14fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 94e14fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94e14fc:
|
Size Change: -13 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
1 failed test on run #7720 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Docs website search > should handle a search string |
Screenshots
|
Review all test suite changes for PR #3757 ↗︎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test case or VRT case that would help us catch that regression in a diff in future?
I thought we had VRT 👀 Waiting to see on this next build. I just added unit tests |
Did we ignore it last time, then? 😛 Need to mark it ready to kick off chromatic |
Seems like I did by accident 👎 |
Passing run #7722 ↗︎Details:
Review all test suite changes for PR #3757 ↗︎ |
Resolves #3753