feat(textarea): add maxRows prop #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: e920577 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e920577:
|
|
Size Change: -9 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Passing run #7666 ↗︎
Details:
Review all test suite changes for PR #3746 ↗︎ |
|||||||||||||||
nkrantz
reviewed
Jan 31, 2024
| @@ -8,7 +8,7 @@ import * as React from "react"; | |||
|
|
|||
| type TextAreaVariants = "default" | "inverse"; | |||
|
|
|||
| export interface TextAreaProps extends HTMLPasteProps<"textarea"> { | |||
| export interface TextAreaProps extends Omit<HTMLPasteProps<"textarea">, "maxRows"> { | |||
There was a problem hiding this comment.
question (non-blocking): just wondering... if you didn't omit maxRows but still added it as a prop below as you are doing, would that have the same effect? would the extended prop be overwritten or vice versa?
nkrantz
approved these changes
Jan 31, 2024
Passing run #7668 ↗︎
Details:
Review all test suite changes for PR #3746 ↗︎ |
|||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio