feat(page-header): add PageHeaderSeparator, also use page header on docs site #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 77d9bd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77d9bd8:
|
|
Size Change: +59 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Passing run #7492 ↗︎
Details:
Review all test suite changes for PR #3731 ↗︎ |
|||||||||||||||
Passing run #7494 ↗︎
Details:
Review all test suite changes for PR #3731 ↗︎ |
|||||||||||||||
serifluous
reviewed
Jan 24, 2024
packages/paste-website/src/component-examples/PageHeaderExamples.ts
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Jan 24, 2024
SiTaggart
reviewed
Jan 24, 2024
SiTaggart
reviewed
Jan 24, 2024
packages/paste-website/src/components/shortcodes/generic-header/index.tsx
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Jan 24, 2024
packages/paste-website/src/pages/components/page-header/index.mdx
Outdated
Show resolved
Hide resolved
serifluous
reviewed
Jan 24, 2024
packages/paste-website/src/components/shortcodes/generic-header/index.tsx
Show resolved
Hide resolved
SiTaggart
reviewed
Jan 24, 2024
| @@ -4,6 +4,8 @@ export const meta = { | |||
| slug: '/blog/', | |||
| }; | |||
|
|
|||
| import {PageHeader, PageHeaderDetails, PageHeaderHeading} from '@twilio-paste/page-header'; | |||
|
|
|||
There was a problem hiding this comment.
suggestion(non-blocking): unsure on feasibility, but... similarly to what I did for Component pages, which you haven't had to update the mdx files for, if we were going to make a big improvement, we could explore layouts for pattern pages, foundation pages, content pages etc, use the page meta object to pass in the data needed to the layout to render the page header for each.
then you wouldn't need to import any of the page header compoents into the mdx pages.
There was a problem hiding this comment.
yeah that would be ideal...
287f807 to
ae88a26
Compare
c2f58ca to
77d9bd8
Compare
SiTaggart
approved these changes
Jan 25, 2024
serifluous
approved these changes
Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.