feat(summary-detail): add package #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 80002eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80002eb:
|
|
Size Change: +260 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Passing run #7515 ↗︎
Details:
Review all test suite changes for PR #3727 ↗︎ |
|||||||||||||||
SiTaggart
reviewed
Jan 22, 2024
packages/paste-core/components/summary-detail/src/SummaryDetailContent.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Jan 22, 2024
packages/paste-core/components/summary-detail/src/SummaryToggleButton.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Jan 22, 2024
nkrantz
reviewed
Jan 24, 2024
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
missing codemods changelog
| "name": "@twilio-paste/summary-detail", | ||
| "version": "0.0.1", | ||
| "category": "interaction", | ||
| "status": "alpha", |
| /** | ||
| * Overrides the default element name to apply unique styles with the Customization Provider | ||
| * | ||
| * @default 'DISCLOSURE' |
There was a problem hiding this comment.
Suggested change
| * @default 'DISCLOSURE' | |
| * @default 'SUMMARY_DETAIL' |
?
|
|
||
| const ToggleButton = React.forwardRef<HTMLButtonElement, SummaryDetailToggleButtonProps>((props, ref) => { | ||
| const rotation = props["aria-expanded"] ? "90" : "0"; | ||
| // todo make this logic better |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/concepts/teams/roles-and-permissions |
|
@nkrantz Thanks for the review and catches, I'm a little bit rusty 😊 |
nkrantz
previously approved these changes
Jan 25, 2024
0d678ad to
3c1590b
Compare
9313f90 to
80002eb
Compare
Passing run #7512 ↗︎
Details:
Review all test suite changes for PR #3727 ↗︎ |
|||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new SummaryDetail component package