-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The deprecated null value for the method round has been changed to zero. #3626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move 554 as the first line of code instead?
Can you also add some tests (in Fixtures)?
@fabpot, I don't see what you mean about 554... we can do it like this:
|
Line is |
tests/Fixtures/filters/round.test
Outdated
@@ -1,6 +1,7 @@ | |||
--TEST-- | |||
"round" filter | |||
--TEMPLATE-- | |||
{{ null|round }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add two other tests for the ceil
and floor
methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
floor
is already tested (that's the last case), but ceil
is indeed missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Thank you @Parovozzzik. |
No description provided.