Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bazel 2.1 #108

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Update to Bazel 2.1 #108

merged 2 commits into from
Mar 9, 2020

Conversation

aherrmann
Copy link
Member

  • Updates the nixpkgs revision used for the Nix shell to the latest of nixpkgs-unstable.
  • As pointed out by @regnat here there was an issue with the Python toolchain tests failing. The reason seems to be an issue in Bazel where it considers //nixpkgs/constraints:nixpkgs and @io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs two different values, even though they refer to the same target.

Toolchain resolution of the Python toolchain erroneously picked the
autodetecting toolchain instead of the nixpkgs provided toolchain.
Debugging with `--toolchain_resolution_debug` shows the following error:

```
Toolchain constraint @bazel_tools//tools/cpp:cc_compiler has value //nixpkgs/constraints:nixpkgs, which does not match value @io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs from the execution platform @io_tweag_rules_nixpkgs//nixpkgs/constraints:linux_x86_64_nixpkgs
```

The issue is that Bazel (tested at version 2.1) considers
`//nixpkgs/constraints:nixpkgs` and
`@io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs` two different
values, even though they refer to the same target.
Copy link
Contributor

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

Tested that locally and everything is green

@thufschmitt thufschmitt merged commit 115cd6d into master Mar 9, 2020
@aherrmann aherrmann deleted the update-bazel branch March 9, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants