Add GHC 9.6.2 bindist to CI matrix #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8f65a10 to
528223b
Compare
528223b to
3b0fad9
Compare
The proto-lens protoc plugin currently crashes with an access violation:
```
ERROR: C:/_bzl/33jjwvv5/external/stackage/BUILD.bazel:772:22: HaskellCabalLibrary @stackage//:language-c [for tool] failed: (Exit 1): cabal_wrapper.exe failed: error executing command (from target @stackage//:language-c)
cd /d C:/_bzl/33jjwvv5/execroot/rules_haskell_tests
SET CC_WRAPPER_CC_PATH=external/rules_haskell_ghc_windows_amd64/mingw/bin/clang
SET CC_WRAPPER_CPU=x64_windows
SET CC_WRAPPER_PLATFORM=windows
SET LANG=C.UTF-8
SET PATH=bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/external/stackage/happy-1.20.1.1/_install/bin;bazel-out/x64_windows-opt-exec-2B5CBBC6/internal/_middlemen;bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/external/alex/_install/bin;bazel-out/x64_windows-opt-exec-2B5CBBC6/internal/_middlemen;C:/Program Files/Git/usr/bin
SET RULES_HASKELL_DOCDIR_PATH=external/rules_haskell_ghc_windows_amd64/doc/html/libraries/base-4.18.0.0
SET RULES_HASKELL_GHC_PATH=external/rules_haskell_ghc_windows_amd64/bin/ghc-9.6.2.exe
SET RULES_HASKELL_GHC_PKG_PATH=external/rules_haskell_ghc_windows_amd64/bin/ghc-pkg-9.6.2.exe
SET RULES_HASKELL_LIBDIR_PATH=external/rules_haskell_ghc_windows_amd64/lib
bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\rules_haskell\haskell\cabal_wrapper.exe bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/external/stackage/language-c_cabal_wrapper_args.json
Access violation in generated code when executing data at 0x7ff75714e360
Attempting to reconstruct a stack trace...
Frame Code address
* 0x6f166fd5d0 0x7ff75714e360
* 0x6f166fd5d8 0x7ffe00000a77
* 0x6f166fd5e0 0x2235758bcc0
```
The pending PR has been merged to master.
04f2439 to
e8365d3
Compare
aherrmann
approved these changes
Nov 28, 2023
stackage_snapshot_9.6.2.yaml
Outdated
Comment on lines
4
to
6
| # See https://github.com/avdv/proto-lens#readme | ||
| - git: https://github.com/avdv/proto-lens | ||
| commit: 2ab0a8d1ec1f54f3d1a0ecd1a257311389126490 |
There was a problem hiding this comment.
Is there a path to upstreaming this?
There was a problem hiding this comment.
This depends on a PR for ghc-source-gen adding support for GHC 9.6 first: google/ghc-source-gen#103
If that is available we could upstream this too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1986