Tests refactor: use a vector of test cases for parsing pyproject.toml tests #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a5186f to
982a43a
Compare
982a43a to
ebacf9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor list of pyproject.toml test cases to use a vector with default values, similar to 'test_vectors' from utils.
Applied to input of
test_parse_pyproject_content__malformatted_poetry_dependencies__yields_no_dependencies, because the rest of the tests have at most 3 parameters perpytest.param.In this PR no new test is added, only code moved around for better readability, application of further changes and unification with FDTestVector style started by @jherland.
Analog of #248 and will close point:
of #166.