Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests refactor: small fix to deduplicate dependencies factory. #245

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

mknorps
Copy link
Collaborator

@mknorps mknorps commented Mar 17, 2023

Small cleanup of tests, to finish fixing point:

gather common helper functions in utils.py and refactor tests cases to use them

of #166.

Remove dependency_factory from tests of and use 'deps_factory' from utils in test of extracting dependencies

@mknorps mknorps force-pushed the maria/tests-cleanup-1 branch from 9639ae9 to 09f25f4 Compare March 17, 2023 07:53
@mknorps mknorps linked an issue Mar 17, 2023 that may be closed by this pull request
5 tasks
tests/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Nour El Mawass <nour.elmawass@tweag.io>
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mknorps mknorps merged commit a7acca5 into main Mar 17, 2023
@mknorps mknorps deleted the maria/tests-cleanup-1 branch March 17, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test refactor
3 participants