spacing problem between dropdowns on dropdown docs #31841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
previously requested changes
Oct 5, 2020
mdo
added a commit
that referenced
this pull request
Oct 9, 2020
- Drop the included .btn-toolbar, no need - Split large and small button examples Closes #31841
|
Replacing this with #31861—while reviewing, I realized we could split those examples and avoid unnecessary changes to our components CSS (which negatively impact all many other |
XhmikosR
added a commit
that referenced
this pull request
Oct 13, 2020
- Drop the included .btn-toolbar, no need - Split large and small button examples Closes #31841 Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that a spacing problem between dropdowns on docs. This problem is caused by left margin even though line breaks. To fix problem, I removed left margin between dropdowns on xs size and applied the margin on over sm size.
You can check the issue on Sizing section of dropdown page. Check it on xs size screen. And this issue is happened to v4 as well as v5.
Preview: https://deploy-preview-31841--twbs-bootstrap.netlify.app/docs/5.0/components/dropdowns/#sizing