-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented color-scheme mix-ins #29552
Conversation
I'm ok with this. Would add two more things:
|
Sounds good. I can add them to the docs tomorrow when I have the chance.
|
Hi @juniorRubyist, Could you have a look at updating the docs? |
I'm not very interested in this. This is a just shorthand of the same fixed phrase no matter who writes. Your request is the same as adding like follows: @mixin reduce-motion {
@media (prefers-reduced-motion: reduce) {
@content;
}
}
@mixin print {
@media print {
@content;
}
} |
@ysds I think that a shorthand for this would make the code cleaner and create less mistakes. (That second example is just flat out redundant.) If you think about it, you have a mixin for the breakpoints. |
@MartijnCuppens Sorry bout that. I pushed changes to the docs. |
We use these mixins quite a lot in our codebase, and we also have I think I'm gonna agree with @ysds here, we got to watch out we don't add too many mixins we don't use ourselves. |
Closes #29551
Adds two new mix-ins
dark-scheme
andlight-scheme
that take a block and wrap them in a media query forprefers-color-scheme
.