Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim trailing whitespace from markdown files #29460

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

MartijnCuppens
Copy link
Member

We don't have trailing whitespaces for any markdown file. It's also quite annoying the trailing whitespaces aren't removed when writing documentation.

@XhmikosR
Copy link
Member

LGTM but this is incomplete anyway, since we don't filter the allowed HTML elements (so as to allow <br> or not).

I need to check all markdown files just in case though.

@MartijnCuppens
Copy link
Member Author

I searched for occurrences of trailing whitespaces in our codebase and it only seems to be present in clipboard.min.js (opened webpack/webpack#9756 to tackle this issue upstream). The markdown files should be ok.

@XhmikosR XhmikosR merged commit 494713b into master Oct 2, 2019
@XhmikosR XhmikosR deleted the master-mc-remove-markdown-whitespace branch October 2, 2019 19:48
lucanos pushed a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants