coveralls: Add COVERALLS_GIT_BRANCH
#29458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dc903e to
b506cfa
Compare
|
I switched to the coveralls action. Works properly, but the build ID is not a number anymore. But a fixed thing is that coveralls now will again run for PRs. We can remove the secret also from the repo settings. I'll keep this open for a while, but we should switch to the official action as soon as the issues are fixed upstream. |
Without this, coveralls didn't receive the branch info thus leading to failures when we switched branches.
b506cfa to
cdc40ee
Compare
|
I'm gonna split the action switch to a new PR |
Johann-S
approved these changes
Oct 2, 2019
XhmikosR
added a commit
that referenced
this pull request
Oct 2, 2019
Without this, coveralls didn't receive the branch info thus leading to failures when we switched branches.
XhmikosR
added a commit
that referenced
this pull request
Oct 8, 2019
Without this, coveralls didn't receive the branch info thus leading to failures when we switched branches.
XhmikosR
added a commit
that referenced
this pull request
Oct 14, 2019
Without this, coveralls didn't receive the branch info thus leading to failures when we switched branches.
lucanos
pushed a commit
to lucanos/bootstrap
that referenced
this pull request
Oct 27, 2019
Without this, coveralls didn't receive the branch info thus leading to failures when we switched branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does pass the ref, but not just the branch name, the whole ref, i.e
refs/head/master.This is an short-term fix until we switch to the official action.
Refs #29457