Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate modal transition duration based on modal-dialog element #27521

Merged
merged 1 commit into from
Oct 28, 2018
Merged

calculate modal transition duration based on modal-dialog element #27521

merged 1 commit into from
Oct 28, 2018

Conversation

Johann-S
Copy link
Member

We get the transition duration from the wrong element (.modal) but we wait for the transitionend event of .modal-dialog so we called emulateTransitionEnd.

Fixes: #27519

@Johann-S Johann-S requested a review from a team October 26, 2018 14:46
@Johann-S Johann-S mentioned this pull request Oct 26, 2018
Closed
@Johann-S Johann-S force-pushed the v4-dev-jo-fix-modal branch 2 times, most recently from 582ef2d to 74c638a Compare October 26, 2018 15:02
@Johann-S Johann-S force-pushed the v4-dev-jo-fix-modal branch from 74c638a to a099be9 Compare October 26, 2018 18:16
@XhmikosR XhmikosR merged commit ffc8d50 into v4-dev Oct 28, 2018
@XhmikosR XhmikosR deleted the v4-dev-jo-fix-modal branch October 28, 2018 21:59
@mdo mdo mentioned this pull request Oct 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johann-S @XhmikosR