Clean up docs Sass code. #27443
Merged
Clean up docs Sass code. #27443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XhmikosR
commented
Oct 15, 2018
- remove unused rules
- use Sass nesting in more places
- use the core mixins in more places
- use the color variables more
* remove unused rules * use Sass nesting in more places * use the core mixins in more places * use the color variables more
528a4f3 to
7c5b3a8
Compare
| // .bd-brand-item .glyphicon-remove { | ||
| // background-color: #d9534f; | ||
| // } | ||
| // Heading content within |
There was a problem hiding this comment.
There are no headings in .bd-brand-item, this can be removed.
There was a problem hiding this comment.
True, but note that I didn't remove all unused CSS. Just whatever I found while digging at it.
|
This is a nice cleanup. I think there is room for more improvements (eg. more usage of utility classes where needed), but that's something we can look into later. |
|
@MartijnCuppens: feel free to clean the docs Sass more later; I'm pretty sure we have more unused stuff there :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.