update toast documentation on accessibility #27185
Conversation
|
About the timeout I chose that value Personnaly the only doubts I have, it's, is it useful to have a show delay ? |
|
@mdo @patrickhlauke: LGTY? |
What do you think about that @XhmikosR ? |
496309d to
c9ffd39
Compare
7ee1f0f to
e17cca3
Compare
|
@Johann-S: not sure to be honest, I'm not sure the branch is stable enough yet. BTW I rebased this and the base branch to resolve the conflicts. |
c9ffd39 to
27dd45d
Compare
|
@Lausselloic I updated the main PR by removing the show delay and fixing our documentation, can you rebase your branch ? |
…e button everywhere just let it when autohide is set to false
e17cca3 to
b86a2b8
Compare
|
finally I did it 😆 |
site/docs/4.1/components/toasts.md
Outdated
|
|
||
| You also need to adapt the `role` and `aria-live` level depending on the content. If it's an important message like an error, use `role="alert" aria-live="assertive"`, otherwise use `role="status" aria-live="polite"` attributes. | ||
|
|
||
| Be carefull to adapt the [`delay` timeout](#options) depending on the content to give all users enough time to read the content. |
There was a problem hiding this comment.
Noticed a typo here, but decided to rewrite this bit. Can you change this? If not, I can push a commit.
As the content you're displaying changes, be sure to update the [`delay` timeout](#options) to ensure people have enough time to read the toast.
site/docs/4.1/components/toasts.md
Outdated
| <div role="alert" aria-live="assertive" aria-atomic="true">...</div> | ||
| </div> | ||
| {% endhighlight %} | ||
|
|
||
| If you use `autohide: false` then you need to add a `close` button into the header to enable users to dismiss that element. |
There was a problem hiding this comment.
Change to:
When using `autohide: false`, you must add a close button to allow users to dismiss the toast.
update documentation following discussion with @patrickhlauke on PR #27155
Maybe need a review for english because it's not my native langage.
Also add a question about default toast timeout actually defined to
500msmaybe most of users will let it as is by copy/paste... don't know what's the usual timer on toaster but maybe increase it by default at 3seconds or 5seconds?